Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sparkle 1.27.1 #411

Merged
merged 1 commit into from
Feb 15, 2022
Merged

Sparkle 1.27.1 #411

merged 1 commit into from
Feb 15, 2022

Conversation

tomasstrba
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/0/1201754098393286/f
CC:

Description:
Sparkle updated from 1.26.0 to 1.27.1

Steps to test this PR:

  1. Prepare Sparkle testing environment (local or remote)
  2. Export two versions of the app, for example 0.19.0 and 0.19.1 (don't forget to properly set a reference to appcast)
  3. Test update of 0.19.0 to 0.19.1

Testing checklist:

  • Test with Release configuration

Internal references:

Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

@tomasstrba
Copy link
Contributor Author

@bstandaert-ddg, please, this PR is pretty time consuming to test, do you have some space to help us with it?

@bstandaert-ddg
Copy link

@tomasstrba How do I export a DMG from Xcode that will work with Sparkle? I was assuming the "External Beta Release" scheme would do it, but that just gives me a .app package as well.

@tomasstrba
Copy link
Contributor Author

@bstandaert-ddg, you need to pack .app into .dmg manually. Please see https://app.asana.com/0/0/1199575589337013/f

@bstandaert-ddg
Copy link

Thanks Tomas!

Looks good to me:

  • Started with a release build from develop branch and an appcast file containing a 0.19.0 from this branch. Upgraded from the develop branch to 0.19.0.
  • Added a 0.19.1 to the appcast, also from this branch.
  • Ran the update check in 0.19.0, and successfully updated to 0.19.1.

@tomasstrba
Copy link
Contributor Author

Thanks a lot Ben! 👍 💯 You are a huge help for us

@tomasstrba tomasstrba merged commit 68a2cea into develop Feb 15, 2022
@tomasstrba tomasstrba deleted the tom/sparkle-update branch February 15, 2022 14:16
samsymons added a commit that referenced this pull request Feb 16, 2022
* develop:
  Sparkle 1.27.1 (#411)
  Disable CVDisplayLing logging (#421)
  Version 0.18.7
samsymons added a commit that referenced this pull request Feb 18, 2022
* develop:
  Fix non-debug builds (#428)
  new tds url (#430)
  Sparkle 1.27.1 (#411)
  Disable CVDisplayLing logging (#421)
  Update Fire Popover graphics (#426)
  Version 0.18.7
  Refresh the address bar when reloading (#413)
  Fix tabs leakage after Drag-Drop (#423)
  Point to BrowserServicesKit 8.0. (#425)
  Import error improvements (#406)
  Replace Burn and Fireproof icons (#416)
  don't disable the UI unless onboarding has been marked as finished (#420)
  fix nested RunLoop waiting (#422)
  Version 0.18.6
samsymons added a commit that referenced this pull request Feb 21, 2022
# By Alexey Martemyanov (2) and others
# Via GitHub (1) and Tomas Strba (1)
* develop:
  Fix crash on SecureVault corruption (#417)
  ensure app usage is sent (#429)
  Fix non-debug builds (#428)
  new tds url (#430)
  Sparkle 1.27.1 (#411)
  Disable CVDisplayLing logging (#421)
  Version 0.18.7

# Conflicts:
#	DuckDuckGo/Menus/MainMenuActions.swift
jonathanKingston pushed a commit that referenced this pull request Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants